Allow "api" package name

DanielRyanSmith · DanielRyanSmith · commit c1ef3a7b6d6c · 2025-12-04T06:53:08.000Z
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -49,12 +49,6 @@ linters:
     gomoddirectives:
       replace-allow-list:
         - launchpad.net/gocheck
-    revive:
-      rules:
-        - name: var-naming
-          arguments:
-            - []
-            - ["api"]
   exclusions:
     generated: lax
     presets:
diff --git a/api/CORS_list.go b/api/CORS_list.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 // CORSList is a list of trusted third-party origins.
 // nolint:gochecknoglobals // TODO: Fix gochecknoglobals lint error
diff --git a/api/bsf_handler.go b/api/bsf_handler.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/bsf_handler_test.go b/api/bsf_handler_test.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
@@ -14,9 +14,9 @@ import (
 
 	"github.com/stretchr/testify/assert"
 
-	"go.uber.org/mock/gomock"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 	"github.com/web-platform-tests/wpt.fyi/shared/sharedtest"
+	"go.uber.org/mock/gomock"
 )
 
 func TestBSFHandler_Success(t *testing.T) {
diff --git a/api/diff.go b/api/diff.go
@@ -1,4 +1,4 @@
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/labels.go b/api/labels.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/labels_medium_test.go b/api/labels_medium_test.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/manifest.go b/api/manifest.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"bytes"
diff --git a/api/manifest_test.go b/api/manifest_test.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"bytes"
diff --git a/api/metadata_cache.go b/api/metadata_cache.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/metadata_handler.go b/api/metadata_handler.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/metadata_handler_test.go b/api/metadata_handler_test.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
@@ -14,11 +14,11 @@ import (
 	"strings"
 	"testing"
 
-	"go.uber.org/mock/gomock"
 	"github.com/stretchr/testify/assert"
 	"github.com/web-platform-tests/wpt.fyi/api/query"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 	"github.com/web-platform-tests/wpt.fyi/shared/sharedtest"
+	"go.uber.org/mock/gomock"
 )
 
 func TestHandleMetadataTriage_Success(t *testing.T) {
diff --git a/api/pending_test_runs.go b/api/pending_test_runs.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/pending_test_runs_medium_test.go b/api/pending_test_runs_medium_test.go
@@ -1,6 +1,6 @@
 //go:build medium
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/results_redirect_handler.go b/api/results_redirect_handler.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"fmt"
diff --git a/api/routes.go b/api/routes.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import "github.com/web-platform-tests/wpt.fyi/shared"
 
diff --git a/api/screenshot_redirect_handler.go b/api/screenshot_redirect_handler.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"fmt"
diff --git a/api/shas.go b/api/shas.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/shas_medium_test.go b/api/shas_medium_test.go
@@ -1,6 +1,6 @@
 //go:build medium
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_history.go b/api/test_history.go
@@ -1,4 +1,4 @@
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_history_test.go b/api/test_history_test.go
@@ -4,7 +4,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_run.go b/api/test_run.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_run_medium_test.go b/api/test_run_medium_test.go
@@ -1,6 +1,6 @@
 //go:build medium
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_runs.go b/api/test_runs.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/test_runs_medium_test.go b/api/test_runs_medium_test.go
@@ -1,6 +1,6 @@
 //go:build medium
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/user.go b/api/user.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"
diff --git a/api/versions.go b/api/versions.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package api
+package api //nolint:revive
 
 import (
 	"context"
diff --git a/api/versions_medium_test.go b/api/versions_medium_test.go
@@ -1,6 +1,6 @@
 //go:build medium
 
-package api
+package api //nolint:revive
 
 import (
 	"encoding/json"

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package api`
	`1`	`+package api //nolint:revive`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"encoding/json"`