Skip to content

Get almost the entire results-processor typed #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
past merged 1 commit into from
Oct 16, 2024
Merged

Get almost the entire results-processor typed #4060

past merged 1 commit into from
Oct 16, 2024

Conversation

@gsnedders
Copy link
Member

@gsnedders gsnedders commented Oct 15, 2024

This should be relatively self-evident to review, and CI should verify whether or not this works.

@gsnedders gsnedders requested review from KyleJu and past October 15, 2024 22:27
KyleJu
KyleJu approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@KyleJu KyleJu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked @jrobbins for help since he has more experience with mypy, but I also looked more into the use of cast() in this PR. LGTM.

Thanks for the PR!

@past past merged commit d6339c4 into web-platform-tests:main Oct 16, 2024
12 checks passed
@gsnedders gsnedders deleted the more-mypy branch October 16, 2024 23:35
@past past mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KyleJu KyleJu KyleJu approved these changes

@past past Awaiting requested review from past

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsnedders @KyleJu @past