Commit e976909
[animation-trigger] Ensure triggered CSS animations are exposed
Normally, we pause a triggered CSS animation at the time of attaching
the trigger. However, this means we will leave as idle a CSS animation
whose trigger name we didn't find. This results in the animation being
idle and not showing up in getAnimations.
We should:
- make them show up in getAnimations by pausing in anticipation of
finding the trigger (which may show up later), and
- spec this behavior.
This CL also addresses the fact that pause() likely should not change
the paused_for_trigger state of the animation.
Bug: 390314945, 465915372
Change-Id: I381ea0cc42772a1e4afb5e13d27631982c8be97d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7228342
Reviewed-by: Kevin Ellis <[email protected]>
Reviewed-by: David Awogbemila <[email protected]>
Commit-Queue: David Awogbemila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1554739}1 parent e962f1a commit e976909
File tree
1 file changed
+19
-11
lines changed- scroll-animations/animation-trigger
1 file changed
+19
-11
lines changedLines changed: 19 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
28 | 27 | | |
29 | | - | |
30 | 28 | | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
34 | 32 | | |
| 33 | + | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
48 | 55 | | |
49 | 56 | | |
50 | 57 | | |
51 | 58 | | |
52 | 59 | | |
53 | | - | |
54 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
55 | 63 | | |
56 | 64 | | |
57 | 65 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
62 | 70 | | |
63 | 71 | | |
64 | 72 | | |
| |||
0 commit comments