Implement NavigationPrecommitController.addHandler #56549
Merged
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows registering a post-commit navigation handler during the pre-commit phase, to allow a multi-step navigation process. Bug: 465487215 Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7222931 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555106}
wpt-pr-bot
approved these changes
Dec 6, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows registering a post-commit navigation handler during the
pre-commit phase, to allow a multi-step navigation process.
Bug: 465487215
Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7222931
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1555106}