-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Allow "style" and "json" in as attribute for modulepreload
#11981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow "style" and "json" in as attribute for modulepreload
#11981
Conversation
as attributeas attribute in modulepreload
as attribute in modulepreloadas attribute for modulepreload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also disallow "json" for <link rel=preload>?
You're right, "json" doesn't really make sense in preload if it's supported for Filed #11995 to track and discuss separately. |
|
I'd rather tackle them together as I have a feeling #11995 will not be addressed anytime soon otherwise. And it would be good to have that infrastructure in place as we add more types, such as |
|
I assumed there would be some window of overlap between the new and deprecated version, which is why I filed a separate bug. But if we can do them in one shot that's great. This feature is a little different in that it's not directly observable, so it does seem safe to just deprecate. I'll update this PR to remove @rniwa - you recently added support for |
|
Latest push handles removing "json" for "preload". I also added the implementation bugs. I'll work on tests next. |
Updates the definition of
modulepreloadto supportas="style"andas="json"for preloading style and JSON module scripts respectively.Fixes #10233
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/indices.html ( diff )
/links.html ( diff )
/semantics.html ( diff )