Refactoring. Change def to val for immutable objects

Author: yoshinorin

src/main/scala/gitbucket/monitoring/services/MachineResources.scala

@@ -8,7 +8,7 @@ import gitbucket.monitoring.utils._
 trait MachineResources {
   private val fileStore = Files.getFileStore(Paths.get("."))
 
-  def cpuCore = Runtime.getRuntime().availableProcessors()
+  val cpuCore = Runtime.getRuntime().availableProcessors()
 
   def getCpu: Either[String, Cpu] = {
     try {

src/main/scala/gitbucket/monitoring/services/SystemInformation.scala

@@ -7,12 +7,12 @@ import scala.sys.process._
 import gitbucket.monitoring.utils._
 
 trait SystemInformation {
-  def timeZone = ZoneId.systemDefault()
+  val timeZone = ZoneId.systemDefault()
   def nowTime = LocalDateTime.now()
   def zoneOffset = timeZone.getRules().getOffset(nowTime)
   def dayOfWeek = nowTime.getDayOfWeek()
 
-  def onDocker: Boolean = {
+  val onDocker: Boolean = {
     try {
       Files.exists(Paths.get("/.dockerenv"))
     } catch {

src/main/scala/gitbucket/monitoring/services/operatingsystem/OperatingSystem.scala

@@ -12,8 +12,7 @@ object OperatingSystem {
 
   val osArch = System.getProperty("os.arch")
   val osName = System.getProperty("os.name")
-  
-  def osType: OSType = {
+  val osType: OSType = {
     if (osName.toLowerCase.contains("linux")) {
       Linux
     } else if (osName.toLowerCase.contains("windows")) {
@@ -25,7 +24,7 @@ object OperatingSystem {
     }
   }
 
-  def osVersion:String = osType match {
+  val osVersion:String = osType match {
     case Windows => {
       (Process("powershell -Command Get-WmiObject Win32_OperatingSystem | %{ $_.Version }") !!).toString
     }
@@ -34,7 +33,7 @@ object OperatingSystem {
     }
   }
 
-  def distribution: String = osType match {
+  val distribution: String = osType match {
     case Linux => {
       try {
         val result = Process("cat /etc/issue") !!
@@ -49,7 +48,7 @@ object OperatingSystem {
     }
   }
 
-  def getInstance = osType match {
+  val getInstance = osType match {
     case OperatingSystem.Linux => new Linux
     case OperatingSystem.Mac => new Mac
     case OperatingSystem.Windows => new Windows