Skip to content

Commit 797d35c

Browse files
committed
Fix MachineResources for Windows
1 parent a395c01 commit 797d35c

File tree

2 files changed

+26
-9
lines changed

2 files changed

+26
-9
lines changed

src/main/scala/gitbucket/monitoring/models/MachineResources.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ class MachineResources extends MachineResourcesBase {
124124
Right(Memory(
125125
totalMem.toString,
126126
(totalMem - availableMem).toString,
127-
"-",
128-
"-",
127+
Message.notSupported,
128+
Message.notSupported,
129129
//(Process("powershell -Command Get-WmiObject -Class Win32_PerfFormattedData_PerfOS_Memory | %{ $_.CacheBytes /1024/1024 }") !!),
130-
"-",
130+
Message.notSupported,
131131
availableMem.toString
132132
))
133133
} catch {

src/main/twirl/gitbucket/monitoring/information/resources.scala.html

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
swap: Either[String, gitbucket.monitoring.models.Swap],
55
diskSpace: gitbucket.monitoring.models.DiskSpace)(implicit context: gitbucket.core.controller.Context)
66
@import context._
7+
@import gitbucket.monitoring.utils.Message
78
@gitbucket.core.html.main("Monitoring") {
89
@gitbucket.core.admin.html.menu("monitoring") {
910
@gitbucket.monitoring.html.navigation(context)
@@ -43,39 +44,55 @@
4344
<div class="panel panel-default">
4445
<div class="panel-heading strong">Used</div>
4546
<div class="panel-body text-right">
46-
@m.used / @m.total MB
47+
<!--HACK: For Windows. Not so good code...-->
48+
@m.used match {
49+
case Message.notSupported => { @gitbucket.monitoring.helper.html.coloring(m.used) }
50+
case _ => { @gitbucket.monitoring.helper.html.coloring(m.used) / @m.total MB }
51+
}
4752
</div>
4853
</div>
49-
</div>
54+
</div>
5055
<div class="col-sm-2">
5156
<div class="panel panel-default">
5257
<div class="panel-heading strong">Free</div>
5358
<div class="panel-body text-right">
54-
@m.free / @m.total MB
59+
<!--HACK: For Windows. Not so good code...-->
60+
@m.free match {
61+
case Message.notSupported => { @gitbucket.monitoring.helper.html.coloring(m.free) }
62+
case _ => { @gitbucket.monitoring.helper.html.coloring(m.free) / @m.total MB }
63+
}
5564
</div>
5665
</div>
5766
</div>
5867
<div class="col-sm-2">
5968
<div class="panel panel-default">
6069
<div class="panel-heading strong">Shared</div>
6170
<div class="panel-body text-right">
62-
@m.shared / @m.total MB
71+
<!--HACK: For Windows. Not so good code...-->
72+
@m.shared match {
73+
case Message.notSupported => { @gitbucket.monitoring.helper.html.coloring(m.shared) }
74+
case _ => { @gitbucket.monitoring.helper.html.coloring(m.shared) / @m.total MB }
75+
}
6376
</div>
6477
</div>
6578
</div>
6679
<div class="col-sm-2">
6780
<div class="panel panel-default">
6881
<div class="panel-heading strong">Buff/Cache</div>
6982
<div class="panel-body text-right">
70-
@m.buff_cache / @m.total MB
83+
<!--HACK: For Windows. Not so good code...-->
84+
@m.buff_cache match {
85+
case Message.notSupported => { @gitbucket.monitoring.helper.html.coloring(m.buff_cache) }
86+
case _ => { @gitbucket.monitoring.helper.html.coloring(m.buff_cache) / @m.total MB }
87+
}
7188
</div>
7289
</div>
7390
</div>
7491
<div class="col-sm-2">
7592
<div class="panel panel-default">
7693
<div class="panel-heading strong">Available</div>
7794
<div class="panel-body text-right">
78-
@m.available / @m.total MB
95+
@gitbucket.monitoring.helper.html.coloring(m.available) / @m.total MB
7996
</div>
8097
</div>
8198
</div>

0 commit comments

Comments
 (0)