Skip to content

Commit f95a0bb

Browse files
committed
gltfpack: Update help to account for vtf/vnf and remove vtn
On further reflection, vtn was added prematurely: it only allows setting the texture coordinate compression mode to default which isn't actually useful until we add automatic modes, and once we do a lot of things will change. This was not very obvious when only vpf and vtf existed, but with vnf as well it's definitely not a good idea to also add vnn... Removing this should hopefully be fine since it was a no-op argument that wasn't documented or advertised anywhere but the command line.
1 parent 8bac922 commit f95a0bb

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

gltf/gltfpack.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,10 +1249,6 @@ int main(int argc, char** argv)
12491249
{
12501250
settings.pos_float = true;
12511251
}
1252-
else if (strcmp(arg, "-vtn") == 0)
1253-
{
1254-
settings.tex_float = false;
1255-
}
12561252
else if (strcmp(arg, "-vtf") == 0)
12571253
{
12581254
settings.tex_float = true;
@@ -1499,7 +1495,7 @@ int main(int argc, char** argv)
14991495
fprintf(stderr, "\t-si R: simplify meshes targeting triangle/point count ratio R (default: 1; R should be between 0 and 1)\n");
15001496
fprintf(stderr, "\t-sa: aggressively simplify to the target ratio disregarding quality\n");
15011497
fprintf(stderr, "\t-slb: lock border vertices during simplification to avoid gaps on connected meshes\n");
1502-
fprintf(stderr, "\nVertices:\n");
1498+
fprintf(stderr, "\nVertex precision:\n");
15031499
fprintf(stderr, "\t-vp N: use N-bit quantization for positions (default: 14; N should be between 1 and 16)\n");
15041500
fprintf(stderr, "\t-vt N: use N-bit quantization for texture coordinates (default: 12; N should be between 1 and 16)\n");
15051501
fprintf(stderr, "\t-vn N: use N-bit quantization for normals and tangents (default: 8; N should be between 1 and 16)\n");
@@ -1508,9 +1504,9 @@ int main(int argc, char** argv)
15081504
fprintf(stderr, "\t-vpi: use integer attributes for positions (default)\n");
15091505
fprintf(stderr, "\t-vpn: use normalized attributes for positions\n");
15101506
fprintf(stderr, "\t-vpf: use floating point attributes for positions\n");
1511-
fprintf(stderr, "\nTexture coordinates:\n");
1512-
fprintf(stderr, "\t-vtn: use normalized attributes for texture coordinates (default)\n");
1507+
fprintf(stderr, "\nVertex attributes:\n");
15131508
fprintf(stderr, "\t-vtf: use floating point attributes for texture coordinates\n");
1509+
fprintf(stderr, "\t-vnf: use floating point attributes for normals\n");
15141510
fprintf(stderr, "\nAnimations:\n");
15151511
fprintf(stderr, "\t-at N: use N-bit quantization for translations (default: 16; N should be between 1 and 24)\n");
15161512
fprintf(stderr, "\t-ar N: use N-bit quantization for rotations (default: 12; N should be between 4 and 16)\n");

0 commit comments

Comments
 (0)