-
Notifications
You must be signed in to change notification settings - Fork 31
Make typeshare an optional dependency #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make typeshare an optional dependency #68
Conversation
106150e to
2debb54
Compare
Progdrasil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, You'll just need to fix the pipeline
2debb54 to
1c87f46
Compare
|
Looks like we need to duplicate those two fields mentioned in the review because the I reverted back to the original code. I'll do a separate PR to fix the Clippy lints. |
|
For the cfg_attr, this will be blocked on 1Password/typeshare#273 |
|
1Password/typeshare#273 is merged, but 1Password/typeshare#274, which points to typeshare's |
|
I'll poke around internally, thanks for reminding me |
1c87f46 to
01c1d33
Compare
|
@Progdrasil done! |
Upstreaming bitwarden#14: