Cleanup and refactor LoadWCSim#372
Open
atcsutton wants to merge 5 commits intoANNIEsoft:Applicationfrom
Open
Conversation
… fix to the PlotWaveforms Makefile to fix a build error
Collaborator
|
Haven't went over in detail yet, but I noticed the workflow build failed. It seems unrelated to the PR, and I haven't found anything in the PR that would break the build. Sometimes this just happens. |
jminock
approved these changes
Feb 13, 2026
Collaborator
jminock
left a comment
jminock
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for cleaning this up!
minor comment changes just to trigger CI with updated workflow.
another tweak to retrigger CI workflow with updated action
yet another workflow attempt
Collaborator
|
alright, the first thing i can't help but notice (because the git diff highlights the entire file as having changed) is that the whitespace has been switched from consistent tab-intenting to a combination of tabs and spaces. |
marc1uk
reviewed
Feb 15, 2026
Collaborator
|
Alright, finally got the CI approval, looks fine to me, i agree it's more readable like this. 👍 |
Removing some debugging couts and changing a last cout into a logmessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Title says it all. LoadWCSim had a lot of copy pasta and this fixes it. This makes it easier to read and make modifications later. I also took the opportunity to adjust layout and formatting to my preferences.
Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)I didn't create anything new, mainly just rearranged, so the last four boxes are unchecked.
Additional Material
I loaded and saved a single WCSim file. Then used LoadANNIEEvent and PrintANNIEEvent to verify that the resulting files are the same (or nearly so). The only "unintended" difference I found was a minor change in the floating point precision of MCParticle::trackLength (eg. 0.563564 → 0.563563) that will have no impact.