Add #ifndef guard for NOMINMAX macro define#232
Closed
kevreco wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Closed
Add #ifndef guard for NOMINMAX macro define#232kevreco wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
kevreco wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Contributor
|
This makes sense. Better would be to undef it after including windows.h though, to avoid leaking that define into the user's code. Could you update this PR for that? Also you'll need to sign off on it per our DCO requirements. You can just force-push an updated commit to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Down the line some projects consuming openfx source code defines there own
NOMINMAXdefine via command line.This result in few warnings like:
This MR fixes that.