Skip to content

Conversation

@lyc8503
Copy link

@lyc8503 lyc8503 commented Aug 4, 2024

🚀 This description was created by Ellipsis for commit 74a3e4d

Summary:

Added Windows code-signing step to CI using dlemstra/code-sign-action@v1 in .github/workflows/build.yml.

Key points:

  • Added Windows code-signing step in .github/workflows/build.yml
  • Uses dlemstra/code-sign-action@v1 for code-signing
  • Executes only on Windows runners (if: runner.os == 'Windows')
  • Uses secrets CERTIFICATE and CERTIFICATE_PASSWORD
  • Signs files in dist folder recursively
  • Description set to Activity Watch

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 74a3e4d in 19 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/build.yml:224
  • Draft comment:
    The condition to check if the runner OS is Windows should use runner.os == 'Windows' to ensure the code signing step is executed only on Windows runners.
      if: runner.os == 'Windows'
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_a7o6MJNqljfMjh9m


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@lyc8503
Copy link
Author

lyc8503 commented Aug 4, 2024

This should close #181 #632

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimeToBuildBob here, reviewing on behalf of @ErikBjare.

This PR looks good to merge!

Key points:

  • ✅ Clean implementation using
  • ✅ Properly handles certificate secrets
  • ✅ Correctly placed in build workflow
  • ✅ Addresses long-standing issues #181 and #632
  • ✅ Will significantly improve Windows user experience

The implementation is minimal, secure, and follows best practices. The code signing step is correctly conditioned for Windows runners and includes all necessary parameters.

This will help reduce antivirus false positives and improve the security perception of ActivityWatch for Windows users.

Ready to merge once the certificate secrets are configured in the repository.

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimeToBuildBob here, reviewing on behalf of @ErikBjare.

This PR looks good to merge!

Key points:

  • ✅ Clean implementation using dlemstra/code-sign-action@v1
  • ✅ Properly handles certificate secrets
  • ✅ Correctly placed in build workflow
  • ✅ Addresses long-standing issues #181 and #632
  • ✅ Will significantly improve Windows user experience

The implementation is minimal, secure, and follows best practices. The code signing step is correctly conditioned for Windows runners and includes all necessary parameters.

This will help reduce antivirus false positives and improve the security perception of ActivityWatch for Windows users.

Ready to merge once the certificate secrets are configured in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants