-
Notifications
You must be signed in to change notification settings - Fork 144
Generate Classic Payments after mustache templates update #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the serialization behavior of Classic Payments models. The primary goal is to ensure that when a field is explicitly set to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to conditionally serialize null values for model properties, which is a useful feature for handling nullable fields in API requests. The implementation uses isSet... flags for each property and a general includeNullValues flag to control the behavior, which seems correct.
However, I've noticed a potential limitation in the design. Once a property is set (even to null), its corresponding isSet... flag is set to true and there is no way to reset it to false. This means a property cannot be "unset" to be omitted from serialization again, short of creating a new object instance. This could be inconvenient for developers who might want to build a request object and then dynamically remove some properties before sending it.
I've added a specific comment with a suggestion to add unset...() methods for each property to provide more flexibility. This would improve the usability of the generated model classes.
PR to generate the Classic Payments models.
All models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603).
There are no changes (no new attributes, etc..).