DPL: keep code checker happy #14966
Merged
DPL: keep code checker happy #14966
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code checker complains about the unique_ptr going out of scope. However this is a false positive because such unique_ptr has a custom deletion policy to mimick the behavior of an observer_ptr. In order to keep the code checker happy, we use release, so that the bare pointer is returned without any complain. Given the custom deleter, the semantic is actually the same.
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code checker complains about the unique_ptr going out of scope.
However this is a false positive because such unique_ptr has a custom
deletion policy to mimick the behavior of an observer_ptr.
In order to keep the code checker happy, we use release, so that the bare
pointer is returned without any complain. Given the custom deleter, the semantic
is actually the same.