[PWGDQ,PWGJE] speed up runMCGen and reshape table #14520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjxiongOvO
requested review from
alibuild,
fjonasALICE,
iarsene,
lucamicheletti93,
maoyx,
mcoquet642,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 1198 errors, |
github-actions
bot
changed the title
[PWGDQ] Please consider the following formatting changes to AliceO2Group#14520
nzardosh
reviewed
Jan 16, 2026
PWGJE/Core/JetDQUtilities.h
Outdated
| candidate.deviationPairKF(), candidate.deviationxyPairKF(), | ||
| candidate.massKFGeoTop(), candidate.chi2overndfKFGeoTop(), | ||
| candidate.tauz(), candidate.tauxy(), candidate.lz(), candidate.lxy()); | ||
| candidate.tauz(), candidate.tauxy(), -999., candidate.lz(), candidate.lxy()); |
Collaborator
There was a problem hiding this comment.
Hi @zjxiongOvO , why do you fill this with a dummy value in the JE framework instead of doing candidate.tauxyPoleJpsiMass() ?
Contributor
Author
There was a problem hiding this comment.
Hello, my original intention was to avoid impacting the workflows of other PWGs as much as possible, but I have already submitted a new PR to fix it
Collaborator
|
Error while checking build/O2Physics/o2 for c04669b at 2026-01-16 19:11: Full log here. |
vkucera
reviewed
Jan 19, 2026
iarsene
previously approved these changes
Jan 19, 2026
auto-merge was automatically disabled
January 19, 2026 13:05
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.