-
Notifications
You must be signed in to change notification settings - Fork 14
[OGUI-1852] Open Bookkeeping from RunNumber ObjectInfoPanel #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexJanson
wants to merge
16
commits into
dev
Choose a base branch
from
feature/QCG/OGUI-1852/open-bookkeeping-from-run-number
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OGUI-1852] Open Bookkeeping from RunNumber ObjectInfoPanel #3272
AlexJanson
wants to merge
16
commits into
dev
from
feature/QCG/OGUI-1852/open-bookkeeping-from-run-number
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
The user should be able to press on an icon that is to be displayed in the object info panel and navigate in a NEW tab to bookkeeipng run-details page of that run number.
For example, at start we load
filter/configurationwhere we send data loaded on server start.We should add a new endpoint:
serviceswhich returns an object of services and their connection links. For start, we will only provide in this object the configuraiton of bookkeeping service:Please add:
Then on front-end side use this data to build the URL needed to access bookkeeping on the run-details page
e.g. of URL
https://ali-bookkeeping.cern.ch/?page=run-detail&runNumber=568864The button should be an icon next to the runNumber and should not be copied when cliking on runNumber
Moreover, if Bookkeeping is not present in the config.js file, this button should not be displayed