Prevent android app from handling oauth routes#13499
Prevent android app from handling oauth routes#13499dylanjeffers wants to merge 1 commit intomainfrom
Conversation
|
raymondjacobson
left a comment
raymondjacobson
left a comment
There was a problem hiding this comment.
tbh, not super super familiar with those this is supposed to work, but i think it looks good to me.
| <category android:name="android.intent.category.BROWSABLE" /> | ||
| <data android:scheme="https" /> | ||
| <data android:scheme="http" /> | ||
| <data android:host="redirect.audius.co" /> |
There was a problem hiding this comment.
just fyi i made changes in the embed player to not use redirect.audius.co, so i think we can probably drop it soon
| <data android:scheme="http" /> | ||
| <data android:host="redirect.audius.co" /> | ||
| <data android:host="audius.co" /> | ||
| <data android:pathPrefix="/oauth" /> |
There was a problem hiding this comment.
how is this a blacklist? it seems like it would match on this?
2 participants
These are some recommended changes in lieu of not being able to do negative path patterns in the manifest.
oauth deep link may still get through, and our main-activity attempts to open browser with the url instead.