Conversation
## Summary - Adds Cloudflare R2 endpoint (`crs.aztec-cdn.foundation`) as primary CRS download source - Falls back to existing AWS S3 bucket (`crs.aztec.network`) on failure - Reduces costs (R2 has no egress fees) and improves reliability ## Changes - **C++**: Added fallback logic in `get_bn254_crs.cpp` with HTTPS support for R2 - **TypeScript**: Added `fetchWithFallback` helper in `net_crs.ts` - **Shell**: Added `download_with_fallback` function in `bootstrap.sh` and `download_bb_crs.sh` - **Tests**: Added fallback tests for both C++ (`CrsFactory.Bn254Fallback`) and TypeScript ## Test plan - [x] C++ `srs_tests` pass (including new `Bn254Fallback` test) - [x] TypeScript `net_crs.test.ts` passes (tests primary download and fallback) - [x] Shell script download verified manually Resolves AztecProtocol/barretenberg#1609
…e is not generated by Noir (#20125) add redundant range constraints when AES, ACIR opcode is not generated by Noir --------- Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: AztecBot <tech@aztecprotocol.com>
abef0ec to
4e1231c
Compare
Any commits made after this event will not be merged.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add Cloudflare R2 as primary CRS host with S3 fallback (#20081)
fix: (AES audit) add redundant range constraints when AES, ACIR opcode is not generated by Noir (#20125)
END_COMMIT_OVERRIDE