Skip to content

Fix flaky workloadIdentityCredentialIdentityBinding test on Windows #36745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minhanh-phan merged 5 commits into from
Dec 9, 2025
Merged

Fix flaky workloadIdentityCredentialIdentityBinding test on Windows #36745

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30678f4
Initial plan
Copilot Nov 25, 2025
bba3360
Fix flaky workloadIdentityCredentialIdentityBinding test cleanup
Copilot Nov 25, 2025
ef2cb98
Refactor cleanup to afterEach block for Certificate Validation tests
Copilot Dec 8, 2025
8056d56
Improve afterEach cleanup with error handling and state reset
Copilot Dec 8, 2025
2248e45
Fix type safety in variable declarations
Copilot Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions sdk/identity/identity/test/internal/node/workloadIdentityCredentialIdentityBinding.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,22 @@ describe("WorkloadIdentityCredential - Identity Binding Configuration", function
});

describe("Certificate Validation & Processing", function () {
let tempDir: string | undefined;
let tempCaFile: string | undefined;

afterEach(async function () {
if (tempDir) {
try {
await fs.rm(tempDir, { recursive: true, force: true });
} catch (error) {
// Ignore cleanup errors to prevent test suite failures
} finally {
tempDir = undefined;
tempCaFile = undefined;
}
}
});

it("should throw error for invalid CA certificate data", async function () {
vi.stubEnv("AZURE_KUBERNETES_TOKEN_PROXY", "https://test-proxy.example.com");
vi.stubEnv("AZURE_KUBERNETES_CA_DATA", "invalid-certificate-data");
Expand All @@ -52,8 +68,8 @@ describe("WorkloadIdentityCredential - Identity Binding Configuration", function
});
it("should validate CA file changes and cache invalidation", async function () {
const invalidCaContent = "invalid-certificate-data";
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "cert-test-"));
const tempCaFile = path.join(tempDir, "ca.pem");
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "cert-test-"));
tempCaFile = path.join(tempDir, "ca.pem");
// Copy valid certificate initially
await fs.copyFile(TEST_CERT_PATH, tempCaFile);

Expand Down Expand Up @@ -100,13 +116,11 @@ describe("WorkloadIdentityCredential - Identity Binding Configuration", function

// Should be a new object reference since cache was invalidated
assert.equal(tlsSettings3.ca, getTestCertificateContent());
await fs.unlink(tempCaFile);
await fs.rmdir(tempDir);
});

it("should handle empty CA file during rotation", async function () {
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "cert-test-"));
const tempCaFile = path.join(tempDir, "ca.pem");
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "cert-test-"));
tempCaFile = path.join(tempDir, "ca.pem");

await fs.copyFile(TEST_CERT_PATH, tempCaFile);

Expand Down Expand Up @@ -143,9 +157,6 @@ describe("WorkloadIdentityCredential - Identity Binding Configuration", function
enableAzureKubernetesTokenProxy: true,
});
}, /CA certificate file is empty/);

await fs.unlink(tempCaFile);
await fs.rmdir(tempDir);
});
});

Expand Down