Argument parsing errors and breaks command execution #36813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywing918
requested review from
benbp,
mikeharder and
weshaggard
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes argument parsing errors in PowerShell automation scripts by removing an invalid --no flag from npm exec commands that was breaking command execution.
Key Changes
- Corrected npm exec command syntax in update-version.ps1 by removing the invalid
--noflag - Applied the same fix to update-changelog-content.ps1 for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/update-version.ps1 | Fixed npm exec command syntax by removing invalid --no flag before the command separator -- |
| eng/scripts/update-changelog-content.ps1 | Fixed npm exec command syntax by removing invalid --no flag before the command separator -- |
MaryGao
reviewed
Dec 5, 2025
| Write-Host "Updating CHANGELOG.md..." -ForegroundColor Cyan | ||
| Write-Host "" | ||
| $command = "npm --prefix $releaseToolsPath exec --no -- update-changelog -- --sdkRepoPath `"$SdkRepoPath`" --packagePath `"$PackagePath`"" | ||
| $command = "npm --prefix $releaseToolsPath exec update-changelog -- --sdkRepoPath `"$SdkRepoPath`" --packagePath `"$PackagePath`"" |
Member
There was a problem hiding this comment.
What is the impact for this argument? why I didn't meet any issue during my local verification?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure/azure-sdk-tools#13215
Remove unnecessary '--no' flag from npm exec commands in update scripts
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists