docs: add Azure RBAC role assignment best practice for Azure Key Vault #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maor Klir <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR enhances the Azure Key Vault documentation by adding Microsoft's recommended Azure RBAC permission model alongside the legacy access policy approach, improving security guidance for users.
Key Changes
- Adds Microsoft's official recommendation to use Azure RBAC instead of legacy Key Vault access policies
- Provides complete Azure RBAC code examples for both Azure AD Applications and User-Assigned Managed Identities
- Maintains backward compatibility by keeping legacy access policy examples with clear labels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Improves documentation and follows Microsoft's recommendation for improved security when managing an Azure Key Vault
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers:
Added documentation and code snippets