Task indentation persistence #4696
Conversation
- Add taskIndentLevels getter/setter to SharedPreferencesUtil - Load saved indent levels on init in ActionItemsPage - Save indent levels when changed via swipe gestures - Add same functionality to DesktopActionsPage for desktop support - Indent levels (0-3) now persist across app restarts - Existing tasks default to indent level 0 if not set Co-authored-by: Nik Shevchenko <[email protected]>
|
Cursor Agent can help with this pull request. Just |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces persistence for task indentation levels, ensuring they are saved and restored across application sessions. The implementation correctly utilizes SharedPreferences for storing the indentation state as a JSON string. The new logic is added to both DesktopActionsPage and ActionItemsPage, with proper loading in initState and saving upon modification of indentation. The code for serialization and deserialization is robust, including error handling for JSON parsing. The changes are consistent with the existing patterns for managing preferences in the codebase. Overall, this is a solid implementation that achieves the stated goal. I have not found any issues of high or critical severity.
|
Hi @kodjima33 — this appears to be a duplicate of #4697 and #4698 (all submitted within a few minutes for the same task indentation persistence feature). Could you confirm which PR is the final version? Recommend closing the other two to keep the review queue clean. |
3 participants
Persist task indentation state to ensure indentation levels are saved and restored across app sessions.