Creates interface for ufunc functions #5399
Merged
+876
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drculhane
force-pushed
the
Closes-5253
branch
from
010c9fc to
a25ee03
Compare
drculhane
force-pushed
the
Closes-5253
branch
from
6880aee to
6934ada
Compare
drculhane
force-pushed
the
Closes-5253
branch
from
6934ada to
8c3d5d1
Compare
ajpotts
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes #5253.
This creates an interface for functions that fall into numpy's "ufunc" category, enabling the optional use of the "where" and "out" parameters.
Four functions are rewritten to use this interface: ceil, floor, trunc, and arctan2.
Note: Proper handling of "where" and "out" causes problems with alignment_verification tests, as these were written when our handling of those parameters didn't match numpy. So I've also updated the alignment tests for ceil, floor, and trunc, and included a comment that further tests will need updating as the functions themselves are.