[Fix] dashscope default base_url error #17584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chenzhaofei01
changed the title
Contributor
Author
|
Strangely, even the latest code—used as-is—fails to pass all the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix dashscope default base_url error
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitI don’t think additional tests are needed, as there’s already a unit test covering my code changes.
The new api_base is ok.
Sorry, I can’t get the unit tests to run on my machine—they keep failing, probably something wrong with my setup.
I only run the test file that I’ve modified.
Type
🐛 Bug Fix
Changes
Update the default base_url of DashScope, because if you use DashScope following the official sample usage (https://docs.litellm.ai/docs/providers/dashscope#sample-usage) and omit the base_url parameter, an error will be raised.