feat(sdk-coin-xdc): add uploadKyc tx builder #7883
Open
+954
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gautam2305
force-pushed
the
SC-4804-uploadKyc
branch
from
b93e718 to
c3d1f36
Compare
Gautam2305
force-pushed
the
SC-4804-uploadKyc
branch
from
c3d1f36 to
dd32f5f
Compare
Gautam2305
commented
Jan 13, 2026
Contributor
Author
Gautam2305
left a comment
Gautam2305
left a comment
There was a problem hiding this comment.
@claude review this PR
| throw new BuildTransactionError('uploadKYC builder not initialized'); | ||
| } | ||
|
|
||
| const uploadKycCall: UploadKycCall = this._uploadKycBuilder.build(); |
Contributor
There was a problem hiding this comment.
isn't this call this._uploadKycBuilder.build(); already happening above in line 51, which is part of the same flow?
Contributor
Author
There was a problem hiding this comment.
thanks for pointing out fixed it
Gautam2305
force-pushed
the
SC-4804-uploadKyc
branch
from
dd32f5f to
ef114a1
Compare
Gautam2305
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SC-4804