fix: issues for angular signals api #1750
Conversation
🦋 Changeset detectedLatest commit: 4733ae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 4733ae2.
☁️ Nx Cloud last updated this comment at |
packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap
Outdated
Show resolved
Hide resolved
sidmohanty11
left a comment
sidmohanty11
left a comment
There was a problem hiding this comment.
apart from the formatting part, this PR LGTM!
# Conflicts: # packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap # packages/core/src/generators/angular/signals/component.ts # packages/core/src/generators/angular/signals/helpers/index.ts
Head branch was pushed to by a user without write access
Done :) @samijaber |
|
@nmerget you'll have to setup commit verification moving forward by the way. We enabled it recently for the Mitosis repo. |
3 participants
Description
Please provide the following information:
Minor fixes for Angular
api=signalsMake sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.