Removes the callback from the handler when the activity is destroyed#361
Removes the callback from the handler when the activity is destroyed#361saketkumar wants to merge 3 commits intoBuildmLearn:bug-fixesfrom saketkumar:leak
Conversation
|
@saketkumar95 It looks that you have created the PR targeted to master branch. Can you please redirect to bug-fixes branch. |
| @Override | ||
| protected void onDestroy() { | ||
| super.onDestroy(); | ||
| if (handler != null) |
There was a problem hiding this comment.
Also reformat your new changes.
|
@opticod Done. :) |
|
@saketkumar95 , looks like you haven't reformatted your code. formatting.Please reformat it. You can automatically do it in Android studio. |
|
@opticod I have reformatted the code. And i saw some more which are not formatted so i thought to reformat the whole project. What do you think about this? |
opticod
dismissed
their stale review
Your travis is failing. Please fix that. Check log at https://travis-ci.org/BuildmLearn/BuildmLearn-Toolkit-Android/builds/193503560
opticod
force-pushed
the
bug-fixes
branch
3 times, most recently
from
a3993ce to
6eea6bd
Compare
|
@saketkumar95 , Are you on this #353 |
|
I just missed this. Will update the branch tonight. :) |
|
Are you still on this ? Will soon start reviewing and merging the PRs. Thanks. |
3 participants
Now it wouldn't cause a leak when we don't need the handler anymore.
@opticod Review and tell me if you need any changes. :)