Skip to content

Conversation

@cfsmp3
Copy link
Contributor

@cfsmp3 cfsmp3 commented Jan 4, 2026

Summary

  • Replaces the inaccurate "X tests queued before this one" message with "Your test VM is being provisioned"
  • Shows actual average completion time for the platform instead of fake queue-based estimates
  • Removes ~30 lines of complex queue calculation code that was producing meaningless numbers
  • Cleans up unused imports (datetime, func, label, GcpInstance)

Problem

The old message claimed:

"This test is still queued. There are X tests queued before this one. Based on the average runtime, this test will be finished in Y hours Z minutes."

This was completely inaccurate because:

  1. Tests run in parallel, not sequentially
  2. Each test gets its own GCP VM immediately
  3. There is no actual queue - all pending tests start at the next cron cycle
  4. The "queue position" had no effect on when a test would start

New Message

"Your test VM is being provisioned. Tests on [platform] typically complete in about X minutes."

This accurately reflects what's happening and gives users a realistic expectation.

Test plan

  • View a test page before the test has started
  • Verify the new message displays correctly
  • Verify the average time is shown (if available in GeneralData)

🤖 Generated with Claude Code

The old message claimed tests were queued sequentially with estimated
wait times based on queue position. This was inaccurate - tests actually
run in parallel on separate GCP VMs.

Changes:
- Replace "X tests queued before this one" with "Your test VM is being
  provisioned"
- Show average completion time for the platform instead of fake queue math
- Remove unused imports (datetime, func, label, GcpInstance)
- Simplify get_data_for_test() by removing complex queue calculations

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
The test was checking for g.db.query calls that no longer exist after
removing the queue calculation logic. Updated to verify the new behavior
that only queries GeneralData for average times.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2026

@canihavesomecoffee canihavesomecoffee merged commit 85f9635 into master Jan 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants