Added de_DE support, deactivated original led mapping#12
Draft
eisenfunk wants to merge 1 commit intoCalcProgrammer1:masterfrom
Draft
Added de_DE support, deactivated original led mapping#12eisenfunk wants to merge 1 commit intoCalcProgrammer1:masterfrom
eisenfunk wants to merge 1 commit intoCalcProgrammer1:masterfrom
Conversation
Owner
|
I've been thinking about ways to support alternate layouts on keyboards over on a GitLab MR that adds similar mapping to Razer boards. I think I would like to add a layout field to the RGBController, expose the en_US/UK keys from the RGBController, and automatically remap them based on en_US/UK to X lookup tables. Since layouts should be standard across all brands of keyboard it keeps this work out of each individual keyboard controller. |
2fcb06b to
8dd50f4
Compare
650c6f2 to
16efabc
Compare
adf9abb to
0b787eb
Compare
ca2ffa6 to
52eda68
Compare
bc35dba to
116a031
Compare
bbd83c9 to
269e7c6
Compare
cd7b90e to
90e4da1
Compare
ceb9ff0 to
f948d6e
Compare
79b7751 to
ba91bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
the RoccatVulcanAimo module has wrong LED mappings on my german keyboard. I think of two reasons for this:
a) vulcan aimo 121 has a different mapping
b) de_DE layout is different to the original one in the code
I can't test anything else than de_DE on my vulcan 121 due to missing hardware (sorry, just one keyboard in my set :) )
But all signs point to possibility b), because the german keymap has also a slightly different Key style in the hardware layout. Producing a series of keyboards with different country codes would make sense.
I've commented the original mapping and added my de_DE mapping for Vulcan Aimo 121. So beware when you accept this pull without reediting.
br and a happy new 2022,
Michael