Skip to content

Conversation

@Vlad0n20
Copy link
Contributor

@Vlad0n20 Vlad0n20 commented Dec 2, 2025

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-9122?atlOrigin=eyJpIjoiMTEyYTk3YWVjYzE2NDVlNDk2NzkwN2RmNzkyMWZiNGQiLCJwIjoiaiJ9

@Vlad0n20 Vlad0n20 changed the base branch from feature/pbs-25-21 to feature/pbs-25-25 December 24, 2025 13:15
batch_size=batch_size,
provider_id=provider_id,
guids=guids
guids=[guids]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert this change because --guids argument has nargs='+' which means guids should be passed like this python manage.py reindex_versioned_preprints --guids abcd abc2 abcd3 and you'll get a list of guids

preprints = Preprint.objects.filter(guids___id__in=guids)
preprints = Preprint.objects.filter(versioned_guids__guid___id__in=guids)
else:
preprints = Preprint.objects.filter(versioned_guids__isnull=False).distinct()
Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it a redundant call?

Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants