-
Notifications
You must be signed in to change notification settings - Fork 355
[ENG-9122] Fix/eng 9122 #11473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/pbs-25-25
Are you sure you want to change the base?
[ENG-9122] Fix/eng 9122 #11473
Conversation
4c6b3b0 to
0e049fa
Compare
0e049fa to
999aa7b
Compare
| batch_size=batch_size, | ||
| provider_id=provider_id, | ||
| guids=guids | ||
| guids=[guids] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can revert this change because --guids argument has nargs='+' which means guids should be passed like this python manage.py reindex_versioned_preprints --guids abcd abc2 abcd3 and you'll get a list of guids
| preprints = Preprint.objects.filter(guids___id__in=guids) | ||
| preprints = Preprint.objects.filter(versioned_guids__guid___id__in=guids) | ||
| else: | ||
| preprints = Preprint.objects.filter(versioned_guids__isnull=False).distinct() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was it a redundant call?
ihorsokhanexoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9122?atlOrigin=eyJpIjoiMTEyYTk3YWVjYzE2NDVlNDk2NzkwN2RmNzkyMWZiNGQiLCJwIjoiaiJ9