Skip to content

London | 26-ITP-January | Ihor Taradaiko | Sprint 3 | Dead code #1061

Open
ihortar wants to merge 5 commits intoCodeYourFuture:mainfrom
ihortar:coursework/sprint-3-dead-code
Open

London | 26-ITP-January | Ihor Taradaiko | Sprint 3 | Dead code #1061
ihortar wants to merge 5 commits intoCodeYourFuture:mainfrom
ihortar:coursework/sprint-3-dead-code

Conversation

@ihortar
Copy link

@ihortar ihortar commented Feb 25, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Exercise - 1
Exercise - 2

@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 26, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 26, 2026
@ihortar ihortar changed the title London | 26-ITP-January | Ihor Taradaiko | Sprint 3 | Coursework-sprint-3-dead-code London | 26-ITP-January | Ihor Taradaiko | Sprint 3 | Dead code Feb 28, 2026
@ihortar ihortar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out and removing are not the same thing; knowing that, can you tidy these files up?

// console.log(greetingStr); - redundant
}

testName = "Aman";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will either result in a variable in the global scope or throw an error. Can you find a way to fix it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were not meant to delete the file with the instructions. Can we bring it back?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note re; comment vs deletion

@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants