West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 2 | coursework/sprint-2#946
Open
alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 2 | coursework/sprint-2#946alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
alizada-dev
added
the
Needs Review
magarpratik
added
Review in progress
magarpratik
reviewed
Feb 15, 2026
| function calculateBMI(weight, height) { | ||
| // return the BMI of someone based off their weight and height | ||
| } No newline at end of file | ||
| let bmi = weight / (height * height); |
There was a problem hiding this comment.
I noticed you've used let here and in most other places. Could we use another keyword which might be a better fit?
magarpratik
reviewed
Feb 15, 2026
| // Use the MDN string documentation to help you find a solution | ||
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function toUpperSnake(str) { |
There was a problem hiding this comment.
I like the name because it's descriptive. 👌
Do you think it could be improved if we make it consistent with the existing toUpperCase?
(Btw, just asking out of curiosity. There is no single right answer.)
magarpratik
reviewed
Feb 15, 2026
| function toPounds(penceString) { | ||
| let value = Number(penceString.slice(0, -1)) / 100; | ||
| return `£${value.toFixed(2)}` | ||
| } |
There was a problem hiding this comment.
Nice! The code is very readable. 👍
magarpratik
reviewed
Feb 15, 2026
| currentOutput === targetOutput, | ||
| `current output: ${currentOutput}, target output: ${targetOutput}` | ||
| ); | ||
|
|
There was a problem hiding this comment.
I think this test is failing. Could you double check?
magarpratik
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint-2 coursework exercises of the Structuring and Testing Data module.