Shadow test scenario #14265
Open
Shadow test scenario #14265
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace templated test scenario service_disabled.fail.sh by a rule-specific test scenario of the same file name in rule service_systemd-journal-upload_enabled. The reason is that the systemd-journal-upload service fails to start if a remote logging URL isn't configured on the system. The new test scenario configures this URL and is very similar to already shadowing pass test scenario in this rule. Resolves: ComplianceAsCode#14210
jan-cerny
added
the
productization-issue
jan-cerny
requested review from
Mab879,
matusmarhefka and
vojtapolasek
as code owners
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace templated test scenario service_disabled.fail.sh by a rule-specific test scenario of the same file name in rule service_systemd-journal-upload_enabled. The reason is that the systemd-journal-upload service fails to start if a remote logging URL isn't configured on the system. The new test scenario configures this URL and is very similar to already shadowing pass test scenario in this rule.
Resolves: #14210
Review Hints: