Remove XSLT templates #14267
Open
Remove XSLT templates #14267
+336
−1,894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate testinfo tables for STIG profiles by using Jinja template instead of using XSLT xccdf2table-profileccirefs.xslt to generate them.
This commit adds a new script create_unlinked_stig_xccdf.py that is used to generate unlinked-stig-xccdf.xml instead of a XSLT template.
Instead of getting the CIS URI from the constants.xslt file in the product directory, we will load the CIS URI directly from the built data stream from the reference element in Benchmark element. This will allow us to remove the constants.xslt file in future.
jan-cerny
requested review from
Mab879,
ggbecker,
marcusburghardt and
vojtapolasek
as code owners
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove XSLT templates from the project. Replace them by new scripts and Jinja templates.
For more details, please read commit messages of all commits.
Rationale:
Review Hints:
Build a product and review generated tables in the
/build/tablesdirectory. For example, for RHEL 8, seetable-rhel8-stig-testinfo.htmltable-rhel8-cces.htmltable-rhel8-stig.html