Rule of Five: Delete copy ops and add move semantics for Concore#470
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Mar 1, 2026
Merged
Conversation
Author
|
Hey @Rahuljagwani @pradeeban also checked concoredocker.hpp, it looks like it may have similar resource ownership patterns. Happy address it separately or any suggestions pls let me know |
Member
|
@avinxshKD sure, go ahead with the docker impl as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concore owns SHM handles and has a destructor, but copy/move semantics weren't explicitly defined. This meant you could accidentally copy an instance and end up with two destructors trying to detach/remove the same shared memory, which is bad.
Deleted copy ctor/assignment and added move semantics so handles get transferred safely, the old instance just nulls them out and becomes harmless.
Fixes #469