Skip to content

Conversation

@pgimalac
Copy link
Member

What does this PR do?

Fix two config issues:

  • remove kublet_api_client_read_timeout from template since it's not used in the code (not even declared in the config)
  • network_devices.autodiscovery.collect_vpn is documented in the template but not declared in the config (resulting in warnings)

Motivation

Fix issues with those configs.

Describe how you validated your changes

Additional Notes

@pgimalac pgimalac requested review from a team as code owners December 10, 2025 13:00
@pgimalac pgimalac requested a review from dustmop December 10, 2025 13:00
@pgimalac pgimalac added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 10, 2025
@github-actions github-actions bot added team/agent-configuration short review PR is simple enough to be reviewed quickly labels Dec 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 56d8f22

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${705.6}$$ < $${706.32}$$ $${+0.04}$$ $${172.98}$$ < $${173.81}$$
agent_deb_amd64_fips $${+0}$$ $${700.93}$$ < $${701.16}$$ $${+0.02}$$ $${172.01}$$ < $${172.71}$$
agent_heroku_amd64 $${-0}$$ $${327.48}$$ < $${327.69}$$ $${+0}$$ $${87.37}$$ < $${88.19}$$
agent_msi $${+0}$$ $${980.07}$$ < $${982.08}$$ $${-0.02}$$ $${141.84}$$ < $${143.01}$$
agent_rpm_amd64 $${-0}$$ $${705.59}$$ < $${706.31}$$ $${+0.06}$$ $${176.04}$$ < $${176.86}$$
agent_rpm_amd64_fips $${+0}$$ $${700.92}$$ < $${701.15}$$ $${+0.03}$$ $${174.04}$$ < $${174.95}$$
agent_rpm_arm64 $${-0}$$ $${691.26}$$ < $${691.67}$$ $${-0.02}$$ $${159.78}$$ < $${160.7}$$
agent_rpm_arm64_fips $${-0}$$ $${687.48}$$ < $${687.54}$$ $${+0.03}$$ $${159.3}$$ < $${160.1}$$
agent_suse_amd64 $${-0}$$ $${705.59}$$ < $${706.31}$$ $${+0.06}$$ $${176.04}$$ < $${176.86}$$
agent_suse_amd64_fips $${+0}$$ $${700.92}$$ < $${701.15}$$ $${+0.03}$$ $${174.04}$$ < $${174.95}$$
agent_suse_arm64 $${-0}$$ $${691.26}$$ < $${691.67}$$ $${-0.02}$$ $${159.78}$$ < $${160.7}$$
agent_suse_arm64_fips $${-0}$$ $${687.48}$$ < $${687.54}$$ $${+0.03}$$ $${159.3}$$ < $${160.1}$$
docker_agent_amd64 $${-0}$$ $${767.93}$$ < $${768.66}$$ $${-0}$$ $${260.75}$$ < $${261.52}$$
docker_agent_arm64 $${-0}$$ $${777.87}$$ < $${778.35}$$ $${+0}$$ $${250.9}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0}$$ $${958.81}$$ < $${959.54}$$ $${-0}$$ $${329.38}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${-0}$$ $${957.47}$$ < $${957.95}$$ $${-0}$$ $${315.51}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${0}$$ $${179.09}$$ < $${179.28}$$ $${-0}$$ $${63.24}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.58}$$ < $${196.79}$$ $${-0.01}$$ $${59.96}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.65}$$ < $${39.3}$$ $${-0}$$ $${14.93}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0.06}$$ $${37.36}$$ < $${37.94}$$ $${+0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.87}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.39}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.87}$$ < $${30.53}$$ $${-0}$$ $${7.88}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.87}$$ < $${30.53}$$ $${-0}$$ $${7.88}$$ < $${8.76}$$
iot_agent_deb_amd64 $${-0}$$ $${42.6}$$ < $${43.19}$$ $${+0}$$ $${11.12}$$ < $${11.98}$$
iot_agent_deb_arm64 $${-0}$$ $${40.34}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${-0}$$ $${40.25}$$ < $${40.86}$$ $${-0}$$ $${9.69}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${-0}$$ $${42.6}$$ < $${43.19}$$ $${+0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${-0}$$ $${42.6}$$ < $${43.19}$$ $${+0}$$ $${11.14}$$ < $${12.0}$$

@pgimalac
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 11, 2025

View all feedbacks in Devflow UI.

2025-12-11 13:59:17 UTC ℹ️ Start processing command /merge


2025-12-11 13:59:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-12-11 14:31:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 986c031 into main Dec 11, 2025
312 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/config-fixes branch December 11, 2025 14:31
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants