-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Config template and component fixes #44064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
joepeeples
approved these changes
Dec 10, 2025
dustmop
approved these changes
Dec 10, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
qa/no-code-change
No code change in Agent code requiring validation
short review
PR is simple enough to be reviewed quickly
team/agent-configuration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix two config issues:
kublet_api_client_read_timeoutfrom template since it's not used in the code (not even declared in the config)network_devices.autodiscovery.collect_vpnis documented in the template but not declared in the config (resulting in warnings)Motivation
Fix issues with those configs.
Describe how you validated your changes
Additional Notes