Skip to content

Conversation

@safchain
Copy link
Contributor

@safchain safchain commented Dec 10, 2025

This reverts commit 3cfd55b.

And fix the root cause of the CI failure

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

@safchain safchain added this to the Triage milestone Dec 10, 2025
@safchain safchain added changelog/no-changelog team/agent-security category/bugfix qa/done QA done before merge and regressions are covered by tests labels Dec 10, 2025
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Dec 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 055b7e3

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${705.39}$$ < $${706.32}$$ $${+0}$$ $${172.91}$$ < $${173.81}$$
agent_deb_amd64_fips $${+0}$$ $${700.73}$$ < $${701.16}$$ $${-0.02}$$ $${171.82}$$ < $${172.71}$$
agent_heroku_amd64 $${0}$$ $${327.21}$$ < $${327.69}$$ $${-0.01}$$ $${87.24}$$ < $${88.19}$$
agent_msi $${0}$$ $${979.83}$$ < $${982.08}$$ $${-0.01}$$ $${141.71}$$ < $${143.01}$$
agent_rpm_amd64 $${0}$$ $${705.38}$$ < $${706.31}$$ $${-0.04}$$ $${175.89}$$ < $${176.86}$$
agent_rpm_amd64_fips $${+0}$$ $${700.72}$$ < $${701.15}$$ $${-0.03}$$ $${173.93}$$ < $${174.95}$$
agent_rpm_arm64 $${+0}$$ $${691.05}$$ < $${691.67}$$ $${+0}$$ $${159.68}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0}$$ $${687.27}$$ < $${687.54}$$ $${-0}$$ $${159.17}$$ < $${160.1}$$
agent_suse_amd64 $${0}$$ $${705.38}$$ < $${706.31}$$ $${-0.04}$$ $${175.89}$$ < $${176.86}$$
agent_suse_amd64_fips $${+0}$$ $${700.72}$$ < $${701.15}$$ $${-0.03}$$ $${173.93}$$ < $${174.95}$$
agent_suse_arm64 $${+0}$$ $${691.05}$$ < $${691.67}$$ $${+0}$$ $${159.68}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0}$$ $${687.27}$$ < $${687.54}$$ $${-0}$$ $${159.17}$$ < $${160.1}$$
docker_agent_amd64 $${+0}$$ $${767.72}$$ < $${768.66}$$ $${+0}$$ $${260.61}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.67}$$ < $${778.35}$$ $${+0.01}$$ $${250.78}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0}$$ $${958.6}$$ < $${959.54}$$ $${+0}$$ $${329.24}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${957.27}$$ < $${957.95}$$ $${+0}$$ $${315.4}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.09}$$ < $${179.28}$$ $${-0}$$ $${63.25}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${0}$$ $${196.58}$$ < $${196.79}$$ $${-0}$$ $${59.96}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.65}$$ < $${39.3}$$ $${-0}$$ $${14.93}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.3}$$ < $${37.94}$$ $${0}$$ $${14.37}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.87}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.38}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.87}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.87}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${+0}$$ $${11.13}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.34}$$ < $${40.92}$$ $${+0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.24}$$ < $${40.86}$$ $${+0}$$ $${9.7}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 10, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 432a43b8-7260-4168-b13e-400989c8534f

Baseline: 055b7e3
Comparison: 164585e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +6.21 [+3.11, +9.30] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +6.21 [+3.11, +9.30] 1 Logs
tcp_syslog_to_blackhole ingress throughput +2.02 [+1.93, +2.11] 1 Logs
ddot_metrics_sum_delta memory utilization +0.89 [+0.69, +1.09] 1 Logs
quality_gate_idle memory utilization +0.54 [+0.49, +0.59] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.37 [+0.33, +0.40] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.34 [+0.27, +0.41] 1 Logs
file_tree memory utilization +0.29 [+0.24, +0.34] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.23 [+0.07, +0.39] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.20 [+0.14, +0.27] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.08 [-0.15, +0.31] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [+0.01, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.40, +0.43] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.07, +0.09] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.13, +0.13] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.38, +0.37] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.43, +0.38] 1 Logs
otlp_ingest_metrics memory utilization -0.12 [-0.28, +0.04] 1 Logs
ddot_metrics memory utilization -0.14 [-0.38, +0.10] 1 Logs
docker_containers_memory memory utilization -0.17 [-0.24, -0.09] 1 Logs
otlp_ingest_logs memory utilization -0.35 [-0.45, -0.24] 1 Logs
quality_gate_metrics_logs memory utilization -0.56 [-0.78, -0.34] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.61 [-3.11, -0.11] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@safchain safchain force-pushed the safchain/re-add-cgroup-pointer-rm branch from 449d2f5 to 18a8bc1 Compare December 11, 2025 09:07
@safchain safchain marked this pull request as ready for review December 11, 2025 11:26
@safchain safchain requested a review from a team as a code owner December 11, 2025 11:26
@safchain safchain force-pushed the safchain/re-add-cgroup-pointer-rm branch from 18a8bc1 to ca55474 Compare December 11, 2025 11:48
@safchain safchain force-pushed the safchain/re-add-cgroup-pointer-rm branch from ca55474 to 164585e Compare December 11, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/bugfix changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants