Fix inverted write() error check in profile exporter#501
Open
xroche wants to merge 1 commit intoDataDog:mainfrom
Open
Fix inverted write() error check in profile exporter#501xroche wants to merge 1 commit intoDataDog:mainfrom
xroche wants to merge 1 commit intoDataDog:mainfrom
Conversation
write() returns -1 on error, not 0. The previous check: - Missed all real errors (ENOSPC, EIO, EPIPE) - False-alarmed on legitimate 0-byte writes Also handle short writes with a loop, since write() may return less than the requested length. Fixes DataDog#498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
write_profile()insrc/exporter/ddprof_exporter.ccwhich checkedwrite() == 0instead ofwrite() < 0.write()returns-1on error, not0. The previous check:The fix also handles short writes with a loop, since
write()may return less than the requested length.Motivation
Profile data was silently lost on disk errors, causing invisible profiling gaps with no diagnostic signal.
How to test the change?
Write to a full filesystem or a closed pipe — the error should now be detected and reported instead of silently ignored.
Classification
Fixes #498