tags from parser: fix parsers, add tests and fallback #14111
+281
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14105
Some parsers were still using the old/unsupported way of setting the
finding.tagsfield. All parsers are now updated to use thefinding.unsaved_tagsfield which is validated and stored correctly.This PR also adds a fallback for any parser that might use the old way by picking up those tags, merging them into the
unsaved_tagsfield and validating/storing them as usual.The import/reimport tests in
test_tags/pywere only testing the API and not the UI. The UI tests have now also been added.