Catch case of wrong atlas when registering dcgs#744
Open
stephen-riggs wants to merge 2 commits intomainfrom
Open
Catch case of wrong atlas when registering dcgs#744stephen-riggs wants to merge 2 commits intomainfrom
stephen-riggs wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 46.90% 46.87% -0.03%
==========================================
Files 91 91
Lines 9673 9679 +6
Branches 1273 1274 +1
==========================================
Hits 4537 4537
- Misses 4917 4922 +5
- Partials 219 220 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the atlas is not in the visit folder we want to avoid crashing. This takes a guess at where the atlas should have been, and will then fall into the else statement below when it tries to glob for an atlas in that location.
Also puts a try-catch around the call from the multigrid control. Means the analyser will not crash but could leave us without a dcg message.