Standards upgrade for PimCore 11

Standards/Pimcore11/phpcs/.php-cs-fixer.dist.php

@@ -0,0 +1,80 @@
+<?php
+
+$rules = [
+  '@PSR1' => true,
+  '@PSR2' => true,
+  'array_syntax' => ['syntax' => 'short'],
+
+  // keep aligned = and => operators as they are: do not force aligning, but do not remove it
+  'binary_operator_spaces' => true,
+  'blank_line_before_statement' => ['statements' => ['return']],
+  'blank_lines_before_namespace' => true,
+  'encoding' => true,
+  'single_line_comment_style' => ['comment_types' => ['hash']],
+  'lowercase_cast' => true,
+  'method_argument_space' => ['on_multiline' => 'ignore'],
+  'class_attributes_separation' => ['elements' => ['method' => 'one']],
+  'class_definition' => ['single_line' => true],
+  'clean_namespace' => true,
+  'concat_space' => ['spacing' => 'one'],
+  'declare_parentheses' => true,
+  'empty_loop_body' => ['style' => 'braces'],
+  'fully_qualified_strict_types' => true,
+  'function_declaration' => true,
+  'general_phpdoc_tag_rename' => ['replacements' => ['inheritDocs' => 'inheritDoc']],
+  'lambda_not_used_import' => true,
+  'linebreak_after_opening_tag' => true,
+  'magic_constant_casing' => true,
+  'native_function_casing' => true,
+  'no_alternative_syntax' => true,
+  'no_blank_lines_after_class_opening' => true,
+  'no_blank_lines_after_phpdoc' => true,
+  'no_empty_comment' => true,
+  'no_empty_phpdoc' => true,
+  'no_empty_statement' => true,
+  'no_extra_blank_lines' => true,
+  'no_leading_import_slash' => true,
+  'no_leading_namespace_whitespace' => true,
+  'no_short_bool_cast' => true,
+  'no_spaces_around_offset' => true,
+  'no_unneeded_control_parentheses' => true,
+  'no_unused_imports' => true,
+  'no_whitespace_before_comma_in_array' => true,
+  'no_whitespace_in_blank_line' => true,
+  'object_operator_without_whitespace' => true,
+  'ordered_imports' => true,
+  'phpdoc_indent' => true,
+  'phpdoc_no_useless_inheritdoc' => true,
+  'phpdoc_scalar' => true,
+  'phpdoc_separation' => true,
+  'phpdoc_single_line_var_spacing' => true,
+  'return_type_declaration' => true,
+  'short_scalar_cast' => true,
+  'single_space_around_construct' => true,
+  'single_quote' => true,
+  'space_after_semicolon' => true,
+  'standardize_not_equals' => true,
+  'ternary_operator_spaces' => true,
+  'trim_array_spaces' => true,
+  'type_declaration_spaces' => true,
+  'types_spaces' => ['space' => 'single'],
+  'unary_operator_spaces' => true,
+  'whitespace_after_comma_in_array' => true,
+];
+
+$finder = (new PhpCsFixer\Finder)
+  ->in([
+    __DIR__ . '/../../../../../../src',
+  ])
+
+  // do not fix views
+  ->notName('*.html.php')
+
+  // using notPath instead of exclude here as they can be nested (install-profiles)
+  ->notPath(__DIR__ . '/../../../../../../var\/config')
+  ->notPath(__DIR__ . '/../../../../../../var\/classes');
+
+// do not enable self_accessor as it breaks pimcore models relying on get_called_class()
+return (new PhpCsFixer\Config)
+  ->setRules($rules)
+  ->setFinder($finder);

Standards/Pimcore11/phpmd/rulesetmd.xml

@@ -0,0 +1,34 @@
+<?xml version="1.0"?>
+<ruleset name="Pimcore 11 rule set"
+         xmlns="http://pmd.sf.net/ruleset/1.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0
+                     http://pmd.sf.net/ruleset_xml_schema.xsd"
+         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
+  <description>
+    Pimcore 11 rule set
+  </description>
+
+  <rule ref="rulesets/cleancode.xml">
+    <exclude name="StaticAccess" />
+    <exclude name="BooleanArgumentFlag" />
+    <exclude name="ElseExpression" />
+  </rule>
+  <rule ref="rulesets/codesize.xml" />
+  <rule ref="rulesets/controversial.xml" />
+  <rule ref="rulesets/design.xml" />
+  <rule ref="rulesets/naming.xml">
+    <exclude name="ShortVariable" />
+    <exclude name="ShortMethodName" />
+  </rule>
+  <rule ref="rulesets/naming.xml/ShortVariable">
+    <properties>
+      <property name="exceptions" description="Comma-separated list of exceptions" value="id,em" />
+    </properties>
+  </rule>
+  <rule ref="rulesets/naming.xml/ShortMethodName">
+    <properties>
+      <property name="exceptions" description="Comma-separated list of exceptions" value="up" />
+    </properties>
+  </rule>
+</ruleset>

Standards/Pimcore11/phpstan/phpstan-bootstrap.php

@@ -0,0 +1,4 @@
+<?php
+
+\Pimcore\Bootstrap::setProjectRoot();
+\Pimcore\Bootstrap::bootstrap();

Standards/Pimcore11/phpstan/phpstan.neon

@@ -0,0 +1,15 @@
+includes:
+    - ../../../../../../vendor/ekino/phpstan-banned-code/extension.neon
+    - ../../../../../../vendor/phpstan/phpstan/conf/bleedingEdge.neon
+    - ../../../../../../vendor/phpstan/phpstan-doctrine/extension.neon
+    - ../../../../../../vendor/phpstan/phpstan-symfony/extension.neon
+parameters:
+    bootstrapFiles:
+        - phpstan-bootstrap.php
+    level: 8
+    symfony:
+        containerXmlPath: ../../../../../../var/cache/dev/App_KernelDevDebugContainer.xml
+    scanDirectories:
+        - ../../../../../../var/cache/dev/Symfony/Config
+    scanFiles:
+        - ../../../../../../vendor/symfony/dependency-injection/Loader/Configurator/ContainerConfigurator.php

composer.json

@@ -31,7 +31,13 @@
     }
   ],
   "require": {
-    "squizlabs/php_codesniffer": "@stable"
+    "squizlabs/php_codesniffer": "@stable",
+    "friendsofphp/php-cs-fixer": "^3.4",
+    "phpmd/phpmd": "^2.15",
+    "ekino/phpstan-banned-code": "^2.0",
+    "phpstan/phpstan": "1.*",
+    "phpstan/phpstan-doctrine": "1.*",
+    "phpstan/phpstan-symfony": "1.*"
   },
   "require-dev": {
     "sclable/xml-lint": "^0.2.4"