Temporary PR to compare hipdlp with latest
#2736
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/HiPdlpWrapper.h highs/pdlp/hipdlp/
…0;70;75;80;86" after CUDA_SEPARABLE_COMPILATION ON
jajhall
commented
Jan 8, 2026
| # set_target_properties(cudalin PROPERTIES | ||
| # CUDA_SEPARABLE_COMPILATION ON | ||
| # CUDA_ARCHITECTURES "60;70;75;80;86" ) | ||
|
|
Member
Author
There was a problem hiding this comment.
@galabovaa I obviously have no idea what
CUDA_ARCHITECTURES "60;70;75;80;86"
might do, but compilation failed until I added it!
jajhall
commented
Jan 8, 2026
| # HI-PDLP branch has | ||
| target_include_directories(cudalin PUBLIC | ||
| "$<BUILD_INTERFACE:${CMAKE_CUDA_PATH}/include>" | ||
| "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../hipdlp>" # Add this for pdhg_kernels.hpp |
Member
Author
There was a problem hiding this comment.
@galabovaa I just added this blindly, since it didn't change any existing build instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@galabovaa Here are a couple of mysteries that I'd rather not try to fix myself in case I break somehting
cuPDLP-C, so is picked up for its files whenlatestis builtpdlp/hipdlp/logger.hppnot being found