GH-1258 Fix Quit/Death message performance by building Notice asynchronous.#1258
Merged
GH-1258 Fix Quit/Death message performance by building Notice asynchronous.#1258
Notice asynchronous.#1258Conversation
…ead blocking by useless creating ton's of Notices
…QuitMessageController` for consistent code style.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the performance issue with quit messages by switching to asynchronous sending. The consolidation of join messages is also a great improvement, reducing redundant broadcasts. My review includes a few suggestions to further enhance code conciseness and maintainability by using more modern Java features like ternary operators and streams. Overall, these are solid improvements to the codebase.
...core/src/main/java/com/eternalcode/core/feature/joinmessage/PlayerJoinMessageController.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/viewer/BukkitViewerProvider.java
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/viewer/BukkitViewerProvider.java
Show resolved
Hide resolved
…ng in join message logic.
Jakubk15
changed the title
Jakubk15
approved these changes
Dec 27, 2025
vLuckyyy
changed the title
Notice asynchronous.
Rollczi
approved these changes
Jan 23, 2026
Rollczi
changed the title
Notice asynchronous.Notice asynchronous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.