You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One integration test is broken, but I don't know why, because it seems totally unrelated to me.
test_game_ratings in test_teammatchmaker.py fails to finish. I found this in the log: WARNING RatingService:rating_service.py:293 gps_update_sql resultset is empty for game_id 41956
It seems like the game_player_stats table fails to update correctly.
Well, since I’m not actively working on the server much anymore we should probably release a less ambitious version of the v2 changes that just includes what we have so far. We can always do a v3 later if more stuff gets done.
I have merged some breaking change stuff onto the v2-develop branch which I then occasionally go and rebase onto develop. We could merge this PR there too and release any time since it sounds like the official client can handle this already. So if you rebase this onto v2-develop and change the base branch to that, we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #834