Java Assignment3 upload by LeeJaewon#32
Open
Pull-Stack wants to merge 2 commits intoFastCampusKDTBackend:mainfrom
Open
Java Assignment3 upload by LeeJaewon#32Pull-Stack wants to merge 2 commits intoFastCampusKDTBackend:mainfrom
Pull-Stack wants to merge 2 commits intoFastCampusKDTBackend:mainfrom
Conversation
ecsimsw
approved these changes
Apr 21, 2023
|
|
||
| private Electronics() { | ||
|
|
||
| } |
|
|
||
| Electronic[] groupByCompanyName(Company company) { | ||
| return Arrays.stream(this.electronicList) | ||
| .filter(electronic -> electronic.getCompanyName().equals(company)) |
Member
There was a problem hiding this comment.
CompanyName과 Company 용어를 통일하면 어떨까요?
getCompanyName()으로 Company를 반환하니 헷갈리네요.
Author
There was a problem hiding this comment.
네 반환되는 값이 Company array이니 메소드명을 groupByCompany()으로 바꾸는게 좋아보입니다!
ecsimsw
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment3