Skip to content

fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447

Open
emyller wants to merge 3 commits intomainfrom
fix/ld-importer/archive-deprecated-flags
Open

fix(LD Importer): Archive deprecated LaunchDarkly flags on import#6447
emyller wants to merge 3 commits intomainfrom
fix/ld-importer/archive-deprecated-flags

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Dec 30, 2025

Import deprecated flags from LaunchDarkly as archived features in Flagsmith.

Changes

  • Archive deprecated flags on import
  • Add "Deprecated" tag to deprecated flags
  • Removed white text from "importing" overlay — it was very hard to read, and not useful.

I was also very annoyed that there is no user feedback after importing, and came to an improvement I like:

image

or

image

Closes #5642

Review effort: 2/5

@emyller emyller requested review from a team as code owners December 30, 2025 20:50
@emyller emyller requested review from adamvialpando and khvn26 and removed request for a team December 30, 2025 20:50
@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 6, 2026 9:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Preview Feb 6, 2026 9:40pm
flagsmith-frontend-staging Ignored Ignored Preview Feb 6, 2026 9:40pm

Request Review

@emyller emyller self-assigned this Dec 30, 2025
@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates fix and removed docs Documentation updates labels Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6447 Finished ✅ Results

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.22%. Comparing base (cf16f3d) to head (1278f04).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6447   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files        1313     1313           
  Lines       47481    47489    +8     
=======================================
+ Hits        46636    46644    +8     
  Misses        845      845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the fix/ld-importer/archive-deprecated-flags branch from 601ab7f to fdcec4b Compare December 31, 2025 03:23
@github-actions github-actions bot added the docs Documentation updates label Dec 31, 2025
@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Dec 31, 2025
khvn26
khvn26 previously approved these changes Jan 1, 2026
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emyller
Copy link
Contributor Author

emyller commented Feb 3, 2026

This is now unblocked by #6476.

@emyller emyller force-pushed the fix/ld-importer/archive-deprecated-flags branch from c75d2e5 to 9b6552b Compare February 6, 2026 19:28
@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Feb 6, 2026
@github-actions github-actions bot added docs Documentation updates fix and removed fix docs Documentation updates labels Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LD Importer: Tag deprecated flags as archived when importing into Flagsmith

3 participants