Skip to content

fix: create change request with mv in v2#6515

Merged
Zaimwa9 merged 5 commits intomainfrom
fix/create-change-request-with-mv-in-v2
Jan 14, 2026
Merged

fix: create change request with mv in v2#6515
Zaimwa9 merged 5 commits intomainfrom
fix/create-change-request-with-mv-in-v2

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jan 12, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Fix 400 on create-change-request
  • Fix percentage_allocation not being updated with feature value change request
  • Fix percentage_allocation not being up with segment override during change request
  • Fixed visual bug with number of changes in variation
  • Fixed value missing in change request segment diff

How did you test this code?

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner January 12, 2026 14:02
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team January 12, 2026 14:02
@cursor
Copy link

cursor bot commented Jan 12, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 13, 2026 2:54pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 13, 2026 2:54pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 13, 2026 2:54pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 12, 2026
@Zaimwa9 Zaimwa9 changed the title Fix/create change request with mv in v2 fix: create change request with mv in v2 Jan 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6515 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6515 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6515 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6515 Finished ✅ Results

@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for kyle-ssg January 12, 2026 14:04
@talissoncosta
Copy link
Contributor

I found an issue on creating a new flag with CR disabled.
Can you check if you are able to reproduce it as well ?

image image

@talissoncosta
Copy link
Contributor

TEST V2 + CR

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments

Copy link
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great @Zaimwa9 . Thanks for handling that.
I've been thought the flows that were failing and it seems to be all done.

@Zaimwa9 Zaimwa9 merged commit f3bd96c into main Jan 14, 2026
25 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/create-change-request-with-mv-in-v2 branch January 14, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants