Features/feeds oceans continents #157
Conversation
|
@uxairibrar Please check the failing tests. Please also add unit tests based on your extended test data. All feeds should contain X publications and the properties, esp. coordinates, should be roughly correct (string matching is fine). |
uxairibrar
force-pushed
the
features/feeds_oceans_continents
branch
from
35c9754 to
1be5672
Compare
There was a problem hiding this comment.
Good work - thank you. I am only not happy with three things:
- The duplicate creation of test data. Please try to load the fixtures for the test case. If you cannot get it to work quickly (30 mins.) then let me know and we merge as is.
- The tests do not actually test if retrieving the "Europe" feed I get the publication that I should get.
- The license URL for the ESRI data source is insufficient, because it links to a page that does not have the license information for the used data set. https://hub.arcgis.com/datasets/esri::world-continents/about is not helpful but looking at the raw metadata is: https://www.arcgis.com/sharing/rest/content/items/57c1ade4fa7c4e2384e6a23f2b3bd254/info/metadata/metadata.xml?format=default&output=html On the other hand, it is useless because it does not list any "vendor". Nevertheless, please use that URL instead.
nuest
left a comment
nuest
left a comment
There was a problem hiding this comment.
I'm going to merge so @uxairibrar can continue with other tasks,
However, I will follow up with a PR on what I actually meant for the tests, because the current tests only see if the database query and the feed content match, but not if there is an issue with the database query.
|
@uxairibrar The tests didn't test anything, because the loop over all regions did not do anything, because the global regions were not loaded for the tests. Please check my changes, and fix the final failing test "django.urls.exceptions.NoReverseMatch: Reverse for 'global_feed' not found. 'global_feed' is not a valid view function or pattern name." |
|
I have fixed that global region, removed that code, because it was for geojson feeds of region, and we don't have that flow right now. |
Closes #51
Added the feeds for different regions and they are displayed on the feeds page in different formats.