Support disabling Kotlin module metadata remapping#1875
Conversation
5834c7c to
14155b7
Compare
|
CC @Tapchicoma |
14155b7 to
8f52e35
Compare
8f52e35 to
55c528a
Compare
| path.endsWith(".kotlin_module") -> { | ||
| if (relocators.isEmpty()) { | ||
| if (relocators.isEmpty() || !enableKotlinModuleRelocation) { | ||
| fileDetails.writeToZip(path) | ||
| } else { |
There was a problem hiding this comment.
We need to expose the transform step for .kotlin_module files.
There was a problem hiding this comment.
As I see - the current change just disables remapping, but still does not trigger generic transformer. It would be nice to add a support for custom .kotlin_module transformer.
There was a problem hiding this comment.
There is a new issue: if the relocators is not empty, remapKotlinModule will be called first. Should we pass the relocated module file to transformers? I believe what you want here is passing the original module file to your custom transformer, and doing nothing from Shadow side. Just like
There was a problem hiding this comment.
Disabling the newly added flag should align the behaviors with 8.x versions. Are you fine with the new flag?
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Outdated
Show resolved
Hide resolved
a9488aa to
a294bd5
Compare
Closes #1874.