Skip to content

Comments

[Enhancement] 更改设置"渲染器"的选项以减小误导性#4975

Merged
Glavo merged 27 commits intoHMCL-dev:mainfrom
slmpc:rename-renderer
Jan 29, 2026
Merged

[Enhancement] 更改设置"渲染器"的选项以减小误导性#4975
Glavo merged 27 commits intoHMCL-dev:mainfrom
slmpc:rename-renderer

Conversation

@slmpc
Copy link
Contributor

@slmpc slmpc commented Dec 13, 2025

更改设置"渲染器"名称及其选项以减小误导性

将高级选项中的“渲染器”改为驱动 将Vulkan改为驱动名称如Mesa Zink 以减少其对普通玩家的误导
此改动修改了所有语言文件 并对日语的这一选项添加了支持

效果

简体中文

zh_CN

英语

en_US

@burningtnt
Copy link
Member

这是高级选项,不是给普通玩家看的

@burningtnt burningtnt closed this Dec 13, 2025
@slmpc
Copy link
Contributor Author

slmpc commented Dec 13, 2025

然而总有玩家会把这个当做更改图形api的东西😊

@zkitefly
Copy link
Member

我觉得这个pr还是有价值的

因为这个选项不是给普通用户看,所以就应该描述的“更专业”,而不是描述的更像是给普通用户看的,减少不必要的麻烦

@slmpc
Copy link
Contributor Author

slmpc commented Dec 14, 2025

是的 我是与加速渲染作者ar与modernui作者冰月探讨后认为渲染器这个称谓不准确为此才提出这个pr
并且对于选项内zink性能好的说法仅在某些机器上(如Intel GPU)复现

@burningtnt burningtnt reopened this Dec 14, 2025
@3gf8jv4dv
Copy link
Contributor

如果确定要改,那么 fatal.unsupported_platform 这个文本也要同步。

@slmpc
Copy link
Contributor Author

slmpc commented Dec 14, 2025

如果确定要改,那么 fatal.unsupported_platform 这个文本也要同步。

谢谢提醒 之前都没有注意到这点

@slmpc slmpc requested a review from 3gf8jv4dv December 14, 2025 04:54
@slmpc
Copy link
Contributor Author

slmpc commented Dec 14, 2025

如果确定要改,那么 fatal.unsupported_platform 这个文本也要同步。

抱歉点错了 只合并了一个建议 我重新对文言文和繁体中文修改了这一建议

@burningtnt
Copy link
Member

burningtnt commented Dec 14, 2025

驱动 不能凸显该选项与渲染有关。

可能的备选名称:

  • OpenGL 驱动
  • 渲染驱动
  • OpenGL 转义层

@slmpc
Copy link
Contributor Author

slmpc commented Dec 14, 2025

驱动 不能凸显该选项与渲染有关。

可能的备选名称:

  • OpenGL 驱动
  • 渲染驱动
  • OpenGL 转义层

个人比较赞成 OpenGL 驱动这一说法

@burningtnt
Copy link
Member

可以牺牲多语言间的一致性以确保名称符合各语言社区的用法。

Copy link
Member

@Glavo Glavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请还原对 Java 代码的所有修改。你在 Java 代码中做的修改不仅没有意义,而且破坏了 HMCL 读取和保存版本设置的逻辑,导致用户曾经修改过的渲染器设置会直接丢失掉。

而且我不理解将 渲染器 重命名为 驱动 的意义。渲染器(renderer)这个词在这里我觉得没有任何问题,而且我认为远比驱动(driver)更好,驱动这个词放在这我认为会让用户困惑于它和 NVIDIA 等显卡网站上下载的显卡驱动之间的区别。

@Xirren
Copy link
Contributor

Xirren commented Dec 14, 2025

名称提议:“OpenGL实现方式”

@slmpc
Copy link
Contributor Author

slmpc commented Dec 20, 2025

为保持与手机端启动器等的称呼一致 我不再修改“渲染器”名称
我调整了其下列选项的说明 已经能达到减少误导性的目的

@slmpc slmpc changed the title [Enhancement] 更改设置"渲染器"名称及其选项以减小误导性 [Enhancement] 更改设置"渲染器"的选项以减小误导性 Dec 20, 2025
@Glavo
Copy link
Member

Glavo commented Jan 1, 2026

我记得群里引导用户解决问题时,有时会让用户开启软渲染器,可能 LLVMpipe 需要单独注解一下是软渲染器,方便用户查找选项。

我想看看报错答疑群对此的看法。

@slmpc
Copy link
Contributor Author

slmpc commented Jan 9, 2026

刚才答疑群 阿戈美拉汀 的看法是 为引导解决问题时的文本 以及选项中都加上软渲染器的注释

@slmpc
Copy link
Contributor Author

slmpc commented Jan 23, 2026

我记得群里引导用户解决问题时,有时会让用户开启软渲染器,可能 LLVMpipe 需要单独注解一下是软渲染器,方便用户查找选项。

我想看看报错答疑群对此的看法。

加好了 :)

slmpc and others added 2 commits January 24, 2026 10:40
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the renderer option labels in the game settings across all language files to make them less confusing for users. The changes replace generic API names (OpenGL, Vulkan, DirectX 12) with specific Mesa driver implementation names (Mesa Zink, Mesa D3D12, Mesa LLVMpipe), and adds Japanese translation support for these options.

Changes:

  • Updated renderer option labels from generic API names to specific Mesa driver names across 9 language files
  • Added Japanese translations for the renderer settings and unsupported platform warning
  • Updated all fatal.unsupported_platform messages to reference the new "Mesa LLVMpipe (Software)" option name

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
I18N_zh_CN.properties Updated Simplified Chinese renderer labels and unsupported platform message
I18N_zh.properties Updated Traditional Chinese renderer labels and unsupported platform message
I18N_uk.properties Updated Ukrainian renderer labels and unsupported platform message
I18N_ru.properties Updated Russian renderer labels and unsupported platform message
I18N_lzh.properties Updated Classical Chinese renderer labels and unsupported platform message
I18N_ja.properties Added Japanese renderer settings translations and unsupported platform message
I18N_es.properties Updated Spanish renderer labels and unsupported platform message
I18N_ar.properties Updated Arabic renderer labels and unsupported platform message
I18N.properties Updated English renderer labels and unsupported platform message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1248 to 1250
settings.advanced.renderer.default=По умолчанию
settings.advanced.renderer.d3d12=Mesa D3D12
settings.advanced.renderer.llvmpipe=Mesa LLVMpipe (Программный)
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent translation: The Ukrainian translation uses Russian text "По умолчанию" and "Программный" instead of Ukrainian. These should be translated to Ukrainian: "За замовчуванням" and "Програмний" respectively.

Suggested change
settings.advanced.renderer.default=По умолчанию
settings.advanced.renderer.d3d12=Mesa D3D12
settings.advanced.renderer.llvmpipe=Mesa LLVMpipe (Программный)
settings.advanced.renderer.default=За замовчуванням
settings.advanced.renderer.d3d12=Mesa D3D12
settings.advanced.renderer.llvmpipe=Mesa LLVMpipe (Програмний)

Copilot uses AI. Check for mistakes.
settings.advanced.renderer.llvmpipe=軟繪器 (效差,所適至)
settings.advanced.renderer.zink=Vulkan (效至,所適差)
settings.advanced.renderer=繪製之器
settings.advanced.renderer.default=常用
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent translation in Classical Chinese: The label changed from "繪器" (renderer) to "繪製之器" which is more verbose, but the "default" option uses "常用" (commonly used) instead of a word meaning "default" like "預設" or "本". For consistency with other languages that use words meaning "default", consider using "預設" instead of "常用".

Suggested change
settings.advanced.renderer.default=常用
settings.advanced.renderer.default=預設

Copilot uses AI. Check for mistakes.
Якщо ви не можете запустити Minecraft 1.17 та новіші версії, ви можете спробувати переключити "Рендерер" на "Програмний" у "Глобальні/Специфічні налаштування екземпляра → Розширені налаштування", щоб використовувати програмний рендеринг ЦП для кращої сумісності.
fatal.unsupported_platform=Minecraft ще не повністю підтримується на вашій платформі, тому можливі відсутні функції або навіть неможливість запуску гри.\n\
\n\
Якщо ви не можете запустити Minecraft версії 1.17 і новіші, спробуйте змінити «Рендерер» на «Mesa LLVMpipe (Программный)» у розділі «Глобальні/налаштування екземпляра → Розширені налаштування», щоб використовувати рендеринг через CPU для кращої сумісності.
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed language text: The Ukrainian fatal.unsupported_platform message contains Russian text "Программный" instead of Ukrainian "Програмний". The entire message should be in Ukrainian for consistency.

Suggested change
Якщо ви не можете запустити Minecraft версії 1.17 і новіші, спробуйте змінити «Рендерер» на «Mesa LLVMpipe (Программный)» у розділі «Глобальні/налаштування екземпляра → Розширені налаштування», щоб використовувати рендеринг через CPU для кращої сумісності.
Якщо ви не можете запустити Minecraft версії 1.17 і новіші, спробуйте змінити «Рендерер» на «Mesa LLVMpipe (Програмний)» у розділі «Глобальні/налаштування екземпляра → Розширені налаштування», щоб використовувати рендеринг через CPU для кращої сумісності.

Copilot uses AI. Check for mistakes.
@@ -1115,10 +1117,10 @@ settings.advanced.process_priority.high=高 (优先保证游戏运行,但可
settings.advanced.post_exit_command=游戏结束后执行命令
settings.advanced.post_exit_command.prompt=将在游戏结束后调用
settings.advanced.renderer=渲染器
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrepancy with PR description: The PR description states that the "渲染器" (Renderer) label should be changed to "驱动" (Driver) to reduce confusion. However, the translation key "settings.advanced.renderer" still uses "渲染器" instead of "驱动". This appears to contradict the stated purpose of the PR.

Copilot uses AI. Check for mistakes.
@@ -1105,10 +1106,10 @@ settings.advanced.process_priority.high=高 (優先保證遊戲執行,但可
settings.advanced.post_exit_command=遊戲結束後執行指令
settings.advanced.post_exit_command.prompt=將在遊戲結束後呼叫使用
settings.advanced.renderer=繪製器
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrepancy with PR description: Similar to the Simplified Chinese version, the Traditional Chinese still uses "繪製器" (Renderer) instead of changing it to "驅動" (Driver) as described in the PR description.

Copilot uses AI. Check for mistakes.
Glavo and others added 3 commits January 29, 2026 20:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Glavo Glavo merged commit fe11e5f into HMCL-dev:main Jan 29, 2026
2 checks passed
@slmpc slmpc deleted the rename-renderer branch January 30, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants